[Wayland-bugs] [Bug 108635] 68dc591af16ebb36814e4c187e4998948103c99c causes XWayland to segfault

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

***@mykolab.com changed:

What |Removed |Added
----------------------------------------------------------------------------
Component|EGL |XWayland
Assignee|mesa-***@lists.freedesktop. |wayland-***@lists.freedesk
|org |top.org
QA Contact|mesa-***@lists.freedesktop. |xorg-***@lists.x.org
|org |
Product|Mesa |Wayland
Version|git |unspecified

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

***@mykolab.com changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|68dc591af16ebb36814e4c187e4 |Mesa master commit
|998948103c99c causes |68dc591af16ebb36814e4c187e4
|XWayland to segfault |998948103c99c causes
| |XWayland to segfault

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

***@mykolab.com changed:

What |Removed |Added
----------------------------------------------------------------------------
Severity|major |critical

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

--- Comment #6 from ***@mykolab.com ---
Mesa commit in question:

https://gitlab.freedesktop.org/mesa/mesa/commit/68dc591af16ebb36814e4c187e4998948103c99c

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

Michel DÀnzer <***@daenzer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@redhat.com

--- Comment #7 from Michel DÀnzer <***@daenzer.net> ---
Adding Lyude, who wrote the Xwayland code using eglQueryDevicesEXT and
eglQueryDeviceStringEXT.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

--- Comment #8 from Mathias Fröhlich <***@web.de> ---
Puh, I think that is because of the binary search implementation being the same
locale dependent than the sort that got fixed yesterday. The strcmp function
used as bsearch compare uses the locale.
I will take care for a patch.

Mathias

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

--- Comment #9 from Emil Velikov <***@gmail.com> ---
According to the man page bsearch doesn't care about the locale.

If some implementation of the C runtime does depend on it, I'm leaning towards
open-coding the bsearch. It's the same amount of code.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

--- Comment #10 from Mathias Fröhlich <***@web.de> ---
Ok, strcmp does not use the locale. It would have been strcoll.
So forget about my comment.

... means needs deeper investigation.

Mathias

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

--- Comment #11 from Chris Wilson <***@chris-wilson.co.uk> ---
diff --git a/src/egl/egl-entrypoint-check b/src/egl/egl-entrypoint-check
index d6a42722a44..c7f3933a29b 100755
--- a/src/egl/egl-entrypoint-check
+++ b/src/egl/egl-entrypoint-check
@@ -7,5 +7,5 @@ then
fi

entrypoints=$(grep EGL_ENTRYPOINT "$srcdir"/main/eglentrypoint.h)
-sorted=$(LC_ALL=C sort <<< "$entrypoints")
+sorted=$(LC_ALL="" sort <<< "$entrypoints")
test "$entrypoints" = "$sorted"

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

Mark Janes <***@intel.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.freedesktop.or
| |g/show_bug.cgi?id=108617

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

--- Comment #12 from Emil Velikov <***@gmail.com> ---
Neither of locale, bsearch or strcmp has anything to do here.
I'm working on fix and will send it out in a bit.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

--- Comment #13 from Emil Velikov <***@gmail.com> ---
Kyle can you try the following. There should be copy of it in your inbox.

https://patchwork.freedesktop.org/patch/260080/

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

--- Comment #14 from Haxk20 <***@gmail.com> ---
(In reply to Emil Velikov from comment #13)

Post by b***@freedesktop.org
Kyle can you try the following. There should be copy of it in your inbox.
https://patchwork.freedesktop.org/patch/260080/

Can confirm that this patch worked for me.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108635

Emil Velikov <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED

--- Comment #15 from Emil Velikov <***@gmail.com> ---
Thanks for the report and check everyone. I've reproduced a crash locally where
this fixes it. Kyle feel free to reopen the problem persists with the below
commit.

commit b3ade6538798ad9bf397d8b386eab3dd8af57f3d
Author: Emil Velikov <***@collabora.com>
Date: Fri Nov 2 18:34:19 2018 +0000

egl/glvnd: correctly report errors when vendor cannot be found