[Wayland-bugs] [Bug 106841] XWayland 1.20.0 breaks Chrome/Chromium rendering

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #9 from Michel DÀnzer <***@daenzer.net> ---
https://patchwork.freedesktop.org/patch/228153/ fixes this for me.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #6 from Olivier Fourdan <***@xfce.org> ---
(In reply to Roman Gilg from comment #5)

I can't reproduce the problems in KWin's Wayland session (with Chrome's own
window decoration and enabled HW acceleration).

Could be that kwin (and weston) both reparent the client window even in the
case of client-side decorations, unlike mutter/gnome-shell.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #8 from Michel DÀnzer <***@daenzer.net> ---
(In reply to Roman Gilg from comment #7)

Another application to test against, which is not fullscreen, with no
decorations is the Steam client.

Steam doesn't hit xwl_present_flip() for me, neither in gnome-shell nor in
Weston.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #4 from Olivier Fourdan <***@xfce.org> ---
For the record, to reproduce, one needs to:

- Use Chrome's own window decorations (i.e. *not* “system itle bar and
borders”)
- Enable hardware acceleration (Settings → Advanced → System → “Use hardware
acceleration when available”)

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #3 from Tony Houghton <***@realh.co.uk> ---
It's definitely not tearing, I described it in more detail in
<https://bugs.chromium.org/p/chromium/issues/detail?id=849682>.

This is a laptop, using just the built-in display, not multiple monitors. I
captured a video of the corruption and attached it to the Chrome bug:
<https://bugs.chromium.org/p/chromium/issues/detail?id=849693>. I could try
capturing the video problem too, but I think the simultaneous decoding and
encoding would overload the CPU and affect the result.

I probably should have mentioned the GPU, it's Intel Skylake HD 520. It's
hidpi, possibly that makes a difference, but my gut feeling is this isn't a
hidpi issue.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

Olivier Fourdan <***@xfce.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Product|xorg |Wayland
Component|Server/General |XWayland
Assignee|xorg-***@lists.x.org |wayland-***@lists.freedesk
| |top.org

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #5 from Roman Gilg <***@gmail.com> ---
I can't reproduce the problems in KWin's Wayland session (with Chrome's own
window decoration and enabled HW acceleration).

Could it be Mutter not syncing the position of the Wayland surface timely
enough to its XWM part? This wouldn't even touch the fullscreen issue though.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #7 from Roman Gilg <***@gmail.com> ---
(In reply to Olivier Fourdan from comment #6)

Post by b***@freedesktop.org
Could be that kwin (and weston) both reparent the client window even in the
case of client-side decorations, unlike mutter/gnome-shell.

You are correct. I just tested it with a debug statement in Xwayland for KWin
and Weston.

Another application to test against, which is not fullscreen, with no
decorations is the Steam client. I'm pretty sure it uses Present all the way.
At the moment my Mesa 32bit libs are too old for that though.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #10 from Olivier Fourdan <***@xfce.org> ---
https://patchwork.freedesktop.org/patch/228153/ fixes the issue with moving the
window, but the issue with video playback flickering is still present though.

I managed to reproduce by starting a playback in youtube on gooble-chrome and
then swithcing to fullscreen while playing.

The area at the top left matching the “old” window size looks fine, but the
rest flickers.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #11 from Olivier Fourdan <***@xfce.org> ---
actually, triggering the issue is fairly random, and can be achieved simply by
pressing “F11” to switch to fullscreen.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #12 from Olivier Fourdan <***@xfce.org> ---
FWIW, this patch https://patchwork.freedesktop.org/series/44489/ fixes the
issue for me.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

Michel DÀnzer <***@daenzer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #13 from Michel DÀnzer <***@daenzer.net> ---
Thanks for the report, fixed in xserver Git master with the commits below.

commit 1993f147d08170f07a72e43f0a0f27687e16967b
Author: Olivier Fourdan <***@redhat.com>
Date: Fri Jun 8 16:23:44 2018 +0200

xwayland: use pixmap size on present flip

commit 10eec2ccb11701fe29ab246acd6c0bdc2991b775
Author: Michel DÀnzer <***@amd.com>
Date: Thu Jun 7 17:55:21 2018 +0200

present/wnmd: Preserve window pixmap's screen_x/y on flip

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

vladimir <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---

--- Comment #14 from vladimir <***@gmail.com> ---
Hello.
This bug still reproduced with xorg-server 1.20.1
OS: Arch Linux
Chromium: 68.0.3440.106

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #15 from Olivier Fourdan <***@xfce.org> ---
(In reply to vladimir from comment #14)

Post by b***@freedesktop.org
Hello.
This bug still reproduced with xorg-server 1.20.1
OS: Arch Linux
Chromium: 68.0.3440.106

Weird, both commit (comment 13) are in xserver 1.20.1 and I just tried again
and it works just fine here, no problem (issue reported in comment 0) using
google-chrome own decorations and hardware acceleration enabled (comment 4).

Are you sure this is the same issue and not something different?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

pacman -Q |grep xorg-server

xorg-server 1.20.1-1
xorg-server-common 1.20.1-1
xorg-server-xwayland 1.20.1-1

My browser config:
"background_mode": {
"enabled": false
},
"browser": {
"enabled_labs_experiments": [ "enable-manual-password-***@2",
"enable-password-***@2", "enable-tcp-fast-open" ],
"last_redirect_origin": ""
},
"hardware_acceleration_mode": {
"enabled": true
},

Im using chromium own decorations too, HW acceleration enabled. Disabling
acceleration does not solve this problem.
Screenshot with bug: https://ibb.co/gbLMCp

Let me know how i can help you to find and reproduce this bug.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #17 from Olivier Fourdan <***@xfce.org> ---
(In reply to vladimir from comment #16)
[...]

Post by b***@freedesktop.org
Im using chromium own decorations too, HW acceleration enabled. Disabling
acceleration does not solve this problem.
Screenshot with bug: https://ibb.co/gbLMCp

That bug doesn't look like the same issue to me.

Post by b***@freedesktop.org
Let me know how i can help you to find and reproduce this bug.

If the bug shows with system window decorations as well, then it's definitely
not the same issue (Present is disabled when toplevel are reparented).

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

If the bug shows with system window decorations as well, then it's definitely not the same issue (Present is disabled when toplevel are reparented).

With system decoration bug not shows. I think its same issue because its
happened after upgrading from 1.9.6 to 1.20.0 and nothing changed after upgrade
to 1.20.1

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

--- Comment #19 from Olivier Fourdan <***@xfce.org> ---
(In reply to vladimir from comment #18)

Post by b***@freedesktop.org
With system decoration bug not shows. I think its same issue because its
happened after upgrading from 1.9.6 to 1.20.0 and nothing changed after
upgrade to 1.20.1

There are a lot of changes between 1.19 and 1.20 that could possibly affect
rendering, though.

Couple of things to try:

1. For peace of mind, what gives `xdpyinfo | grep "release number"` on your
affected system?

2. Can you try using Xephyr with glamor accel:

a. Run a Xephyr server with glamor, e.g.:
$ Xephyr -glamor -screen 1280x1024 :12

b. Run a window manager on that server, e.g. mutter:
$ DISPLAY=:12 mutter --x11

b. Close all your chromium windows

c. Run chromium on that Xephyr server
$ DISPLAY=:12 chromium-browser

3. Can you check if xserver 1.20rc1 and 1.20rc2 are affected (Present support
for Xwayland was added in between)

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

Post by b***@freedesktop.org
`xdpyinfo | grep "release number"`

vendor release number: 12001000

With Xephyr bug not shows.

I will try to build 1.20rc1 and rc2 on this weekend.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106841

Michel DÀnzer <***@daenzer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED

--- Comment #21 from Michel DÀnzer <***@daenzer.net> ---
(In reply to vladimir from comment #18)

I think its same issue because its happened after upgrading from 1.9.6 to
1.20.0 and nothing changed after upgrade to 1.20.1

The bugs this report is about are fixed in 1.20.1. Please file your own report.